-
Notifications
You must be signed in to change notification settings - Fork 16
Align Duration.prototype.round()
to latest specification
#317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
857bc8b
to
5494c45
Compare
Running the test262 with
|
/// | ||
/// Spec: <https://tc39.es/proposal-temporal/#sec-temporal.duration.prototype.round> | ||
/// | ||
// Spec last accessed: 2025-05-16, <https://github.com/tc39/proposal-temporal/tree/c150e7135c56afc9114032e93b53ac49f980d254> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oooh, this is actually really useful! IMO we should start doing something like this for all our spec-related methods.
(with enough tooling put into it, we could have something that keeps track of the oldest parts of the codebase that could be out of date with the latest specification, but that's just an idea)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(with enough tooling put into it, we could have something that keeps track of the oldest parts of the codebase that could be out of date with the latest specification, but that's just an idea)
I like the idea of a tool for checking spec docs, maybe we should have something more structured so it's easier to parse and harder to mistype, maybe something like:
Spec(2025-05-16): <https://github.com/tc39/proposal-temporal/tree/c150e7135c56afc9114032e93b53ac49f980d254>
Or maybe just a date so it's easier to type, should be enough info to pin point a commit?
git log --oneline --since="2025-01-05" --until="2025-01-06"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me overall. Were you planning on looking into the abstract methods of round
as well or were they all basically up to date?
I'll look into the abstract methods in a separate PR, don't want this PR to become too big 😅 From what I saw they where up-to-date at least the ones that where called directly in round. |
Sounds good to me. I'm fine with this merged as is. I'm mostly concerned about |
Resolves #188