Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OS-agnostic handling of end-of-line characters #524

Merged
merged 2 commits into from
May 8, 2024
Merged

Conversation

bmish
Copy link
Owner

@bmish bmish commented Apr 28, 2024

Attempt to fix #523 fix #522 fix #510.

@bmish bmish added the bug Something isn't working label Apr 28, 2024
lib/string.ts Dismissed Show dismissed Hide dismissed
@bmish bmish marked this pull request as ready for review May 8, 2024 16:10
@bmish bmish merged commit 4852197 into main May 8, 2024
9 checks passed
@bmish bmish deleted the newline-handling-os branch May 8, 2024 16:11
@bmish bmish changed the title fix: OS-agnostic handling of end-of-line characters OS-agnostic handling of end-of-line characters May 8, 2024
@fisker
Copy link

fisker commented May 9, 2024

This breaks on Windows if markdown files are using \n.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False Option warning on Windows Duplicated auto-generated rules header on Windows Docs get regenerated
2 participants