fix: update tests #24
Conversation
|
Warning Rate limit exceeded@bmazzarol has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 15 minutes and 48 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
WalkthroughThis pull request updates dependency versions and standardizes test assertions. In the source generator project, package references are upgraded. Meanwhile, multiple test files have been refactored to replace FluentAssertions with standard Xunit assertions, including adjustments to error message verifications. The test project file is updated to include several dependency version bumps, package removals, and the addition of a new using directive. One test file also updates a method’s access modifier from private to internal. Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Test Results0 tests 0 ✅ 0s ⏱️ Results for commit 37d807b. ♻️ This comment has been updated with latest results. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (2)
Tuxedo.Tests/AnalyserTests.cs(2 hunks)Tuxedo.Tests/Tuxedo.Tests.csproj(1 hunks)
🧰 Additional context used
🪛 GitHub Actions: CI Build
Tuxedo.Tests/Tuxedo.Tests.csproj
[warning] 1-1: Package 'Microsoft.CodeAnalysis.CSharp.Workspaces 1.0.1' was restored using '.NETFramework,Version=v4.6.1, .NETFramework,Version=v4.6.2, .NETFramework,Version=v4.7, .NETFramework,Version=v4.7.1, .NETFramework,Version=v4.7.2, .NETFramework,Version=v4.8, .NETFramework,Version=v4.8.1' instead of the project target framework 'net8.0'. This package may not be fully compatible with your project.
[warning] 1-1: Package 'Microsoft.CodeAnalysis.Workspaces.Common 1.0.1' was restored using '.NETFramework,Version=v4.6.1, .NETFramework,Version=v4.6.2, .NETFramework,Version=v4.7, .NETFramework,Version=v4.7.1, .NETFramework,Version=v4.7.2, .NETFramework,Version=v4.8, .NETFramework,Version=v4.8.1' instead of the project target framework 'net8.0'. This package may not be fully compatible with your project.
[warning] 1-1: Package 'Microsoft.Composition 1.0.27' was restored using '.NETFramework,Version=v4.6.1, .NETFramework,Version=v4.6.2, .NETFramework,Version=v4.7, .NETFramework,Version=v4.7.1, .NETFramework,Version=v4.7.2, .NETFramework,Version=v4.8, .NETFramework,Version=v4.8.1' instead of the project target framework 'net8.0'. This package may not be fully compatible with your project.
[error] 1-1: Version conflict detected for xunit.extensibility.core. Install/reference xunit.extensibility.core 2.9.3 directly to project Tuxedo.Tests to resolve this issue.
[error] 1-1: Tuxedo.Tests -> Verify.Xunit 28.9.0 -> xunit.extensibility.execution 2.9.3 -> xunit.extensibility.core (= 2.9.3).
[error] 1-1: Tuxedo.Tests -> xunit 2.9.2 -> xunit.core 2.9.2 -> xunit.extensibility.core (= 2.9.2).
🔇 Additional comments (4)
Tuxedo.Tests/AnalyserTests.cs (2)
163-164: LGTM! Clean transition to standard Xunit assertions.The changes correctly replace FluentAssertions with standard Xunit assertions while maintaining the same verification logic.
232-236: LGTM! Clean transition to standard Xunit assertions.The changes correctly replace FluentAssertions with standard Xunit assertions while maintaining the same verification logic.
Tuxedo.Tests/Tuxedo.Tests.csproj (2)
31-33: LGTM! Good addition of global using directive.The addition of the global using directive for Xunit aligns well with the removal of FluentAssertions and standardization of test assertions.
23-23: Verify compatibility with .NET 8.The pipeline shows warnings about package compatibility with .NET 8.0.
Run the following script to check for newer versions that might be more compatible:
|
|
Not building atm |
Summary by CodeRabbit
Chores
FluentAssertionspackage reference from the project.Tests