Merge pull request #172 from bmazzarol/dependabot/nuget/SonarAnalyzer…

….CSharp-8.54.0.64047 chore(deps): Bump SonarAnalyzer.CSharp from 8.53.0.62665 to 8.54.0.64047
bmazzarol · Mar 11, 2023 · 7e3bb38 · 7e3bb38
2 parents 3b5fc22 + 58550c2
commit 7e3bb38
Show file tree

Hide file tree

Showing 16 changed files with 25 additions and 33 deletions.
diff --git a/BunsenBurner.AutoFixture/BunsenBurner.AutoFixture.csproj b/BunsenBurner.AutoFixture/BunsenBurner.AutoFixture.csproj
@@ -52,7 +52,7 @@
             <PrivateAssets>all</PrivateAssets>
             <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
         </PackageReference>
-        <PackageReference Include="SonarAnalyzer.CSharp" Version="8.53.0.62665">
+        <PackageReference Include="SonarAnalyzer.CSharp" Version="8.54.0.64047">
             <PrivateAssets>all</PrivateAssets>
             <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
         </PackageReference>

diff --git a/BunsenBurner.Background/BunsenBurner.Background.csproj b/BunsenBurner.Background/BunsenBurner.Background.csproj
@@ -53,7 +53,7 @@
             <PrivateAssets>all</PrivateAssets>
             <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
         </PackageReference>
-        <PackageReference Include="SonarAnalyzer.CSharp" Version="8.53.0.62665">
+        <PackageReference Include="SonarAnalyzer.CSharp" Version="8.54.0.64047">
             <PrivateAssets>all</PrivateAssets>
             <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
         </PackageReference>

diff --git a/BunsenBurner.BenchmarkDotNet/BunsenBurner.BenchmarkDotNet.csproj b/BunsenBurner.BenchmarkDotNet/BunsenBurner.BenchmarkDotNet.csproj
@@ -53,7 +53,7 @@
             <PrivateAssets>all</PrivateAssets>
             <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
         </PackageReference>
-        <PackageReference Include="SonarAnalyzer.CSharp" Version="8.53.0.62665">
+        <PackageReference Include="SonarAnalyzer.CSharp" Version="8.54.0.64047">
             <PrivateAssets>all</PrivateAssets>
             <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
         </PackageReference>

diff --git a/BunsenBurner.Bogus/BunsenBurner.Bogus.csproj b/BunsenBurner.Bogus/BunsenBurner.Bogus.csproj
@@ -52,7 +52,7 @@
             <PrivateAssets>all</PrivateAssets>
             <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
         </PackageReference>
-        <PackageReference Include="SonarAnalyzer.CSharp" Version="8.53.0.62665">
+        <PackageReference Include="SonarAnalyzer.CSharp" Version="8.54.0.64047">
             <PrivateAssets>all</PrivateAssets>
             <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
         </PackageReference>

diff --git a/BunsenBurner.DependencyInjection/BunsenBurner.DependencyInjection.csproj b/BunsenBurner.DependencyInjection/BunsenBurner.DependencyInjection.csproj
@@ -52,7 +52,7 @@
             <PrivateAssets>all</PrivateAssets>
             <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
         </PackageReference>
-        <PackageReference Include="SonarAnalyzer.CSharp" Version="8.53.0.62665">
+        <PackageReference Include="SonarAnalyzer.CSharp" Version="8.54.0.64047">
             <PrivateAssets>all</PrivateAssets>
             <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
         </PackageReference>

diff --git a/BunsenBurner.FunctionApp/BunsenBurner.FunctionApp.csproj b/BunsenBurner.FunctionApp/BunsenBurner.FunctionApp.csproj
@@ -52,7 +52,7 @@
             <PrivateAssets>all</PrivateAssets>
             <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
         </PackageReference>
-        <PackageReference Include="SonarAnalyzer.CSharp" Version="8.53.0.62665">
+        <PackageReference Include="SonarAnalyzer.CSharp" Version="8.54.0.64047">
             <PrivateAssets>all</PrivateAssets>
             <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
         </PackageReference>

diff --git a/BunsenBurner.Hedgehog/BunsenBurner.Hedgehog.csproj b/BunsenBurner.Hedgehog/BunsenBurner.Hedgehog.csproj
@@ -52,7 +52,7 @@
             <PrivateAssets>all</PrivateAssets>
             <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
         </PackageReference>
-        <PackageReference Include="SonarAnalyzer.CSharp" Version="8.53.0.62665">
+        <PackageReference Include="SonarAnalyzer.CSharp" Version="8.54.0.64047">
             <PrivateAssets>all</PrivateAssets>
             <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
         </PackageReference>

diff --git a/BunsenBurner.Http/BunsenBurner.Http.csproj b/BunsenBurner.Http/BunsenBurner.Http.csproj
@@ -53,7 +53,7 @@
             <PrivateAssets>all</PrivateAssets>
             <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
         </PackageReference>
-        <PackageReference Include="SonarAnalyzer.CSharp" Version="8.53.0.62665">
+        <PackageReference Include="SonarAnalyzer.CSharp" Version="8.54.0.64047">
             <PrivateAssets>all</PrivateAssets>
             <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
         </PackageReference>

diff --git a/BunsenBurner.Logging/BunsenBurner.Logging.csproj b/BunsenBurner.Logging/BunsenBurner.Logging.csproj
@@ -55,7 +55,7 @@
             <PrivateAssets>all</PrivateAssets>
             <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
         </PackageReference>
-        <PackageReference Include="SonarAnalyzer.CSharp" Version="8.53.0.62665">
+        <PackageReference Include="SonarAnalyzer.CSharp" Version="8.54.0.64047">
             <PrivateAssets>all</PrivateAssets>
             <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
         </PackageReference>

diff --git a/BunsenBurner.Logging/DummyLogger.cs b/BunsenBurner.Logging/DummyLogger.cs
@@ -1,4 +1,5 @@
 using System.Collections;
+using System.Collections.Concurrent;
 using System.Diagnostics.CodeAnalysis;
 using Microsoft.Extensions.Logging;
 
@@ -13,7 +14,7 @@ public sealed record DummyLogger<T> : ILogger<T>, IEnumerable<LogMessage>, IDisp
     private readonly string _ownerClassName;
     private readonly LogMessageStore _store;
     private readonly Sink? _sink;
-    private IEnumerable<Scope> _scopes = Enumerable.Empty<Scope>();
+    private readonly ConcurrentDictionary<Scope, byte> _scopes = new();
 
     internal DummyLogger(LogMessageStore store, string ownerClassName, Sink? sink)
     {
@@ -37,7 +38,7 @@ public void Log<TState>(
             eventId,
             exception,
             formatter(state, exception),
-            _scopes.Select(x => x.State)
+            _scopes.Keys.Select(x => x.State)
         );
         _store.Log(message);
         _sink?.Write(message);
@@ -49,22 +50,15 @@ public void Log<TState>(
     /// <inheritdoc />
     public IDisposable BeginScope<TState>(TState state) where TState : notnull
     {
-        lock (_scopes)
-        {
-            var scope = new Scope(state, this);
-            _scopes = _scopes.Append(scope);
-            return scope;
-        }
+        var scope = new Scope(state, this);
+        _scopes.AddOrUpdate(scope, _ => byte.MinValue, (_, b) => b);
+        return scope;
     }
 
     private sealed record Scope(object State, DummyLogger<T> Parent) : IDisposable
     {
         [ExcludeFromCodeCoverage]
-        public void Dispose()
-        {
-            lock (Parent._scopes)
-                Parent._scopes = Parent._scopes.Where(x => x != this);
-        }
+        public void Dispose() => Parent._scopes.TryRemove(this, out _);
     }
 
     /// <inheritdoc />
@@ -76,11 +70,9 @@ public void Dispose()
     /// <inheritdoc />
     public void Dispose()
     {
-        foreach (var scope in _scopes)
-        {
+        foreach (var scope in _scopes.Keys)
             scope.Dispose();
-        }
-        _scopes = Enumerable.Empty<Scope>();
+        _scopes.Clear();
     }
 }
 

diff --git a/BunsenBurner.NUnit/BunsenBurner.NUnit.csproj b/BunsenBurner.NUnit/BunsenBurner.NUnit.csproj
@@ -53,7 +53,7 @@
             <PrivateAssets>all</PrivateAssets>
             <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
         </PackageReference>
-        <PackageReference Include="SonarAnalyzer.CSharp" Version="8.53.0.62665">
+        <PackageReference Include="SonarAnalyzer.CSharp" Version="8.54.0.64047">
             <PrivateAssets>all</PrivateAssets>
             <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
         </PackageReference>

diff --git a/BunsenBurner.Verify.NUnit/BunsenBurner.Verify.NUnit.csproj b/BunsenBurner.Verify.NUnit/BunsenBurner.Verify.NUnit.csproj
@@ -52,7 +52,7 @@
             <PrivateAssets>all</PrivateAssets>
             <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
         </PackageReference>
-        <PackageReference Include="SonarAnalyzer.CSharp" Version="8.53.0.62665">
+        <PackageReference Include="SonarAnalyzer.CSharp" Version="8.54.0.64047">
             <PrivateAssets>all</PrivateAssets>
             <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
         </PackageReference>

diff --git a/BunsenBurner.Verify.Xunit/BunsenBurner.Verify.Xunit.csproj b/BunsenBurner.Verify.Xunit/BunsenBurner.Verify.Xunit.csproj
@@ -52,7 +52,7 @@
             <PrivateAssets>all</PrivateAssets>
             <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
         </PackageReference>
-        <PackageReference Include="SonarAnalyzer.CSharp" Version="8.53.0.62665">
+        <PackageReference Include="SonarAnalyzer.CSharp" Version="8.54.0.64047">
             <PrivateAssets>all</PrivateAssets>
             <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
         </PackageReference>

diff --git a/BunsenBurner.Xunit/BunsenBurner.Xunit.csproj b/BunsenBurner.Xunit/BunsenBurner.Xunit.csproj
@@ -53,7 +53,7 @@
             <PrivateAssets>all</PrivateAssets>
             <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
         </PackageReference>
-        <PackageReference Include="SonarAnalyzer.CSharp" Version="8.53.0.62665">
+        <PackageReference Include="SonarAnalyzer.CSharp" Version="8.54.0.64047">
             <PrivateAssets>all</PrivateAssets>
             <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
         </PackageReference>

diff --git a/BunsenBurner/BunsenBurner.csproj b/BunsenBurner/BunsenBurner.csproj
@@ -52,7 +52,7 @@
             <PrivateAssets>all</PrivateAssets>
             <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
         </PackageReference>
-        <PackageReference Include="SonarAnalyzer.CSharp" Version="8.53.0.62665">
+        <PackageReference Include="SonarAnalyzer.CSharp" Version="8.54.0.64047">
             <PrivateAssets>all</PrivateAssets>
             <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
         </PackageReference>

diff --git a/commitlint.config.js b/commitlint.config.js
@@ -1,8 +1,8 @@
 module.exports = {
     extends: ['@commitlint/config-conventional'],
     rules: {
-        "header-case": [1, "always", "sentence-case"],
-        "header-max-length": [2, "always", 100],
+        "subject-case": [0, 'never'],
+        "subject-max-length": [2, "always", 100],
         "scope-enum": _ => [
             2,
             "always",