Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Line painter fix using debouncing #153

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

AbbyGi
Copy link
Contributor

@AbbyGi AbbyGi commented Sep 7, 2021

Description

This PR uses the debounce decorator from bluesky-live to space out the callbacks coming from the new_data event so that we don't lock up the application when new data is coming in faster than the app can handle. The kafka and zmq dispatchers have been updated to process new data when it comes in and the LOADING_LATENCY values have been increased.

Motivation and Context

These changes are to help ease the line painter issue where the app receiving live data would lock up because it couldn't handle the new data fast enough.

How Has This Been Tested?

Tested interactively with replayed "live" data from the IOS beamline

@AbbyGi AbbyGi requested a review from danielballan September 7, 2021 20:26
@AbbyGi
Copy link
Contributor Author

AbbyGi commented Sep 7, 2021

Relies on bluesky/bluesky-live#19

@AbbyGi AbbyGi requested review from dmgav and mrakitin September 7, 2021 20:40
Copy link
Member

@mrakitin mrakitin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have much to add, but I can't provide a very informed review as I don't know the codebase very well. Maybe worth having a meeting to go over the architecture and the structure of the code and the goals.

By the way, are the CI failures expected?

@AbbyGi
Copy link
Contributor Author

AbbyGi commented Sep 13, 2021

@mrakitin, the more important PR to look at would be the bluesky-live PR here if you get a chance. This PR relies on changes from the bluesky-live PR, so CI failures are expected right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants