[馃惔] Go back on account switches #4012
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://social-app-pr-4012.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cp1q697jbltc738b7n1g. |
|
mozzius
reviewed
May 15, 2024
| @@ -31,10 +32,31 @@ type Props = NativeStackScreenProps< | |||
| CommonNavigatorParams, | |||
| 'MessagesConversation' | |||
| > | |||
|
|
|||
| let prevDid: string | undefined | |||
There was a problem hiding this comment.
A bit odd having state outside of React? Shouldn't this be in a ref?
There was a problem hiding this comment.
It can't be because the whole tree is gettin nuked when see switch accounts. Ran into the same problem with notifications as well.
|
Talked to Hailey about this, this is fine-ish but it would be much better to have a |
|
Yea this would be useful in some other notification logic too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.