-
Notifications
You must be signed in to change notification settings - Fork 894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Russian translation #3875
base: main
Are you sure you want to change the base?
Add Russian translation #3875
Conversation
Thank you so much @ponfertato! Do you happen to know any other russian speakers who could review this? |
There is no one in particular at the moment, I have requested help from the Bluesky audience, it could probably take a while to get there 👀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some stylistic consistency opportunities in addition to the ones highlighted by other reviewer. Really cool to see this effort!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall it’s good, I’ve read up to 1840 line (will continue later) and left some nitpicky comments and suggestions.
for consistency I think it is better to define terms:
- post as пост, not сообщение ;
- app password as пароль приложения;
- follow as подписка, not слежка;
- feed as лента;
- maybe account as аккаунт? Учетная запись is a bit much.
#: src/Navigation.tsx:290 | ||
#: src/view/screens/AccessibilitySettings.tsx:63 | ||
msgid "Accessibility Settings" | ||
msgstr "Настройки Доступности" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably доступности should be lowercase
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would have done the same thing if it weren't for line 81, which has a lowercase in it.
I'd love to help with this, but it would be cool to see the translation directly in the interface. Perhaps you could publish messages.js for this translation, I'll try to locally replace one of the links like "https://bsky.app/static/js/src/locale/locales/en/messages.js" with the translation file, or something like that. |
Greetings, I'm not sure why you need .js, there's a .po file with the translation 👀 |
Oh, I just saw that I gave a link to 404. I don’t understand much about how translations work, but in fact on the bsky site translations in the .po format are not used. Instead, they are turned into a js file with json inside. My idea was to locally replace one of the translations for the bsky.app site with this one, but I don't think I can use .po for this. Well, or am I just wrong, and is there some easier way to try out the translation directly on the site, rather than reading the translation strings? |
Ahh, I see your point. The point is that this translation is currently used in the bsky fork. I plan to add it to the source code of the project in order to build it into the main product in the future. You can familiarize yourself with the .po file. There are links to the lines of code that have been translated, for example: #: src/view/com/threadgate/WhoCanReply.tsx:158
msgid "<0/> members"
msgstr "<0/> участников" Where msgid is the original string and msgstr is its Russian translation, link: https://github.com/potatoenergy/social-app/blob/11e63802ec493aa1e0efd403168489359b777a36/src/locale/locales/ru/messages.po#L29C1-L31C25 |
I tried to compile your fork, but it seems there are some problems with the paths for ru localization.
In all other languages I get a |
I couldn't find what the problem was, but I was able to replace one of the translations with ru, so that yarn created |
В ручную объеденил исправленный RU с самым новым EN. Могут быть ошибки но быстрый тест проблем не выявил.
Добавлены новые строки для перевода
I wrote a small guide on how you can try translation directly to bsky.app: potatoenergy#2 (comment) (it's in russian) |
Translation corrections + new translation lines
@@ -91,6 +92,10 @@ export async function dynamicActivate(locale: AppLanguage) { | |||
await import('@formatjs/intl-pluralrules/locale-data/pt') | |||
break | |||
} | |||
case AppLanguage.ru: { | |||
i18n.loadAndActivate({locale, messages: messagesRu}) | |||
break |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at the other language codes, I think there might be a line missing here?
await import('@formatjs/intl-pluralrules/locale-data/ru')
Greetings!
Sketched out a translation into Russian, as a base language was used #3552 with my corrections and additions. If there are any conflicts in the translation, welcome feedback!