move app-password to dotenv file #50
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would it maybe make more sense to just read it from STDIN (in some password entering mode that hides typed characters)? Publishing a feed is something that will usually only be done once and then maybe a couple of times at most when editing the name/description, so even having it in an .env file in plain text feels like unnecessary risk for basically zero added convenience. (I have no idea how to do this in Node) |
|
Something like this https://www.npmjs.com/package/password-prompt |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simple PR moving the app password to be pulled from the dotenv file for the publishFeedGen script. This will help prevent accidental password checkins, since the dotenv file is by default included in the gitignore.