Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up lexicons #41

Open
dholms opened this issue Jun 2, 2023 · 1 comment · May be fixed by #90
Open

Clean up lexicons #41

dholms opened this issue Jun 2, 2023 · 1 comment · May be fixed by #90

Comments

@dholms
Copy link
Contributor

dholms commented Jun 2, 2023

I did a dumb copy/paste job in the lexicon folder. clean that up to only necessary lexicons
@aendra-rininsland
Copy link

aendra-rininsland commented Jun 19, 2023 •
edited

Is there any reason to keep a lexicons folder instead of using https://www.npmjs.com/package/@atproto/lexicon?

I might just be really bad at TypeScript but whenever I try to access an object like create.record.embed.external.thumbs I get "Object is of type 'unknown'" which feels like an issue with the TS def.

@aendra-rininsland aendra-rininsland mentioned this issue Mar 20, 2024
Open
aendra-rininsland pushed a commit to aendra-rininsland/feed-generator that referenced this issue Mar 20, 2024
Lexicon cleanup:
8185d66 
* Removes src/lexicons
* Replaces with imports from respective upstream packages
* Replaces ts-node with tsx, namely because @atproto/bsky doesn't export lexicons
  * See: bluesky-social/atproto#2353
  * Merging bluesky-social/atproto#2354 will allow reverting to ts-node

Fixes bluesky-social#41.
@aendra-rininsland aendra-rininsland linked a pull request Mar 20, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Lexicon cleanup aendra-rininsland/feed-generator
2 participants
@aendra-rininsland @dholms