-
Notifications
You must be signed in to change notification settings - Fork 397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export lexicons from @atproto/bsky package #2353
Comments
aendra-rininsland
pushed a commit
to aendra-rininsland/atproto
that referenced
this issue
Mar 20, 2024
aendra-rininsland
pushed a commit
to aendra-rininsland/feed-generator
that referenced
this issue
Mar 20, 2024
* Removes src/lexicons * Replaces with imports from respective upstream packages * Replaces ts-node with tsx, namely because @atproto/bsky doesn't export lexicons * See: bluesky-social/atproto#2353 * Merging bluesky-social/atproto#2354 will allow reverting to ts-node Fixes bluesky-social#41.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'm trying to do a PR for bluesky-social/feed-generator#41 and the biggest issue I keep running into is that
@atproto/bsky
doesn't export a lexicon at all. Specifically I'm needing:Server
class exported by@atproto/bsky/src/lexicon
ids
andlexicons
(specificallyassertValidXrpcMessage()
) from@atproto/bsky/src/lexicon/lexicons
createServer()
from@atproto/bsky/src/lexicon
It feels like
@atproto
packages that use the lexicon auto-generator tool should export those in their own namespace where possible to prevent the necessity of needing to use the lexicon auto-generator tool in downstream packages (e.g. individual feed generators created by thefeed-generator
template.)The text was updated successfully, but these errors were encountered: