Refactor batch 1: extract core settings and configuration assembly - #86
Open
DaanRijpkema wants to merge 1 commit into
Open
DaanRijpkema wants to merge 1 commit into
DaanRijpkema wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Core settings definitions and API configuration assembly still lived in
bluem.php, mixing WordPress reads and display labels with field structure and default resolution. This batch moves the schema intoBluemCoreOptionsand saved-value/default resolution into the sharedBluemConfigurationBuilder.Existing procedural entrypoints remain compatibility adapters. Literal gettext calls and recipient escaping stay in the WordPress wrapper so translation extraction is preserved. The builder accepts any ordered feature definitions and has no WordPress or gateway dependency, allowing future feature services to share it through composition.
No functionality changes: field definitions, defaults, feature precedence, optional module handling, saved value types, and the returned
stdClassremain unchanged. The already-mergedBluemOptionLookupis reused; module-status extraction belongs to existing PR #68 and is excluded here.Validation:
git diff --checkpass.Isolation: this branch starts from master and is independent of bugfix PR #85. Future request-lookup and payment-transition batches own different methods/files. A three-way merge check confirmed no conflicts with #85. The updated roadmap describes shared service boundaries and requires explicit sub-batch labeling for any future dependent PR.