Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear apt lists when building docker images #8

Merged
merged 5 commits into from
Oct 23, 2023
Merged

Clear apt lists when building docker images #8

merged 5 commits into from
Oct 23, 2023

Conversation

678098
Copy link
Contributor

@678098 678098 commented Oct 21, 2023

No description provided.

678098 and others added 5 commits October 21, 2023 20:01
@678098
Minimize layer size in dev.Dockerfile
caa2477 
Signed-off-by: Evgeny Malygin <[email protected]>

Signed-off-by: Evgeny Malygin <[email protected]>
@678098
Minimize layer size in amqpprox.Dockerfile
3f8c6c1 
Signed-off-by: Evgeny Malygin <[email protected]>
@678098
Remove sudo from amqpprox.Dockerfile
cf7a118 
Signed-off-by: Evgeny Malygin <[email protected]>

Signed-off-by: Evgeny Malygin <[email protected]>
@678098
Return sudo to amqpprox.Dockerfile
154d8f0 
Signed-off-by: Evgeny Malygin <[email protected]>
@678098
Add comment amqpprox.Dockerfile
2e2ede7 
Signed-off-by: Evgeny Malygin <[email protected]>
adamncasey
adamncasey approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@adamncasey adamncasey left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems sensible to keep these images small. Will make installing extra things slower if using docker for interactive development but could always revert if there are side effects

@adamncasey adamncasey merged commit becec17 into bloomberg:main Oct 23, 2023
5 checks passed
@678098 678098 deleted the patch-1 branch October 23, 2023 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamncasey adamncasey adamncasey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@678098 @adamncasey