Frame: decode payload length to return early [unverified] #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
678098
commented
Nov 5, 2023
| return Frame::PARTIAL; | ||
| } | ||
|
|
||
| // Finally decode the skipped parts of the header. | ||
| bsl::memcpy(&frame->d_type, &buffer[0], sizeof(frame->d_type)); |
There was a problem hiding this comment.
Side effect: partial Frame object will not be modified in any way during decode.
678098
commented
Nov 5, 2023
| bdlb::BigEndianUint32 payloadLength; | ||
| bsl::memcpy(&payloadLength, &buffer[3], sizeof(payloadLength)); | ||
|
|
||
| if ((frameOverhead() + payloadLength) > bufferLen) { | ||
| if (bufferLen < (frameOverhead() + payloadLength)) { |
There was a problem hiding this comment.
Turned from left to right, similar to line 65
Signed-off-by: Evgeny Malygin <[email protected]>
678098
force-pushed
the
231105_partial_frame_decode
branch
from
f7ae7d3
to
5134cab
Compare
678098
changed the title
|
Closing this PR, the other PR contains the same changes with Verified status |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small optimization for partial
Frames.I have a feeling though that it makes things a bit more complicated, especially addressing buffer via exact offsets like
buffer[3].Might be good to add
const size_tconstants for these offsets.