Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor framer test to fix unused variable warning #20

Merged
merged 3 commits into from
Nov 2, 2023
Merged

Refactor framer test to fix unused variable warning #20

merged 3 commits into from
Nov 2, 2023

Conversation

ahsanabbas123
Copy link
Contributor

@ahsanabbas123 ahsanabbas123 commented Nov 2, 2023 •
edited
Loading

Problem statement

Building with -Wall -Werror on linux was giving a -Werror=ununsed-variable

Proposed changes

Changed to directly check value in assert

This passes the build for consuming from vcpkg to make the port in microsoft/vcpkg#34797 work.

@ahsanabbas123 ahsanabbas123 merged commit 52e583c into bloomberg:main Nov 2, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamncasey adamncasey adamncasey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahsanabbas123 @adamncasey