Make find_package work for rmqcpp #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* find_package? * cmake_install_libdir * use CMAKE_CURRENT_SOURCE_DIR for BUILD_INTERFACE * export target command * export config * export dest * test install to multiple locations * export config to prefix/share/rmqcpp * rm export and only install * export targets * add Config.cmake.in * make target_link_libraries interface instead of public * find_dependency ZLIB * find_dependency in cmake.in, change ns * revert explicit find_dependency * find_package in cmake.in * namespace rmqcpp::
ahsanabbas123
commented
Oct 25, 2023
Comment on lines
+26
to
+28
| target_include_directories(rmq PUBLIC $<INSTALL_INTERFACE:include> $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/rmqt>) | ||
| target_include_directories(rmq PUBLIC $<INSTALL_INTERFACE:include> $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/rmqp>) | ||
| target_include_directories(rmq PUBLIC $<INSTALL_INTERFACE:include> $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/rmqa>) |
There was a problem hiding this comment.
These generator expressions are required if we are creating a relocatable package (with no absolute paths) which uses install(TARGETS) and install(EXPORT) later to produce the rmqcppTargets.cmake file.
Comment on lines
+4
to
+6
| foreach(dep bal;OpenSSL;ZLIB) | ||
| find_package(${dep}) | ||
| endforeach() |
There was a problem hiding this comment.
These are needed so that the consuming upstream application does not need to explicitly do find_package(dep) for deps of rmqcpp.
| NAMESPACE rmqcpp::) | ||
|
|
||
| include(CMakePackageConfigHelpers) | ||
| configure_package_config_file(${CMAKE_CURRENT_SOURCE_DIR}/Config.cmake.in |
There was a problem hiding this comment.
This uses Config.cmake.in as input and produces the rmqcppConfig.cmake which find_package looks for.
| install(EXPORT rmqcppTargets | ||
| FILE rmqcppTargets.cmake | ||
| DESTINATION ${CMAKE_INSTALL_PREFIX}/share/rmqcpp | ||
| NAMESPACE rmqcpp::) |
There was a problem hiding this comment.
We decided to go with rmqcpp::rmq be how users link to rmqcpp, with rmqcpp::rmqtestmocks a possibility in future.
adamncasey
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem statement
Make
find_package(rmqcpp REQUIRED)work for applications installing rmqcpp using a package manager like vcpkg.Proposed changes
rmqcppTargets.cmakeandrmqcppConfig.cmake[generated using theConfig.cmake.in] files.rmqperftestwith a local vcpkg registry overlay with armqcppport to installrmqcpp.