Add bulk import tests #5268
Add bulk import tests #5268
Conversation
morgando
commented
Jul 9, 2025
morgando
commented
- Test dropping src table while we're copying files to dst db
- Test running election on src db while we're copying files to dst db
There was a problem hiding this comment.
Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 7/615 tests failed ⚠.
The first 10 failing tests are:
bulkimport
reco-ddlk-sql
unionpar_maxqueue
phys_rep_tiered_nosource_generated
sc_lotsoftables_logicalsc_generated
sc_lotsoftables
insert_lots_large_tran_generated
morgando
force-pushed
the
bulk_import_tests
branch
7 times, most recently
from
e280542 to
23f70d7
Compare
| @@ -380,6 +403,116 @@ function test_resume_is_blocked() { | |||
| ) | |||
| } | |||
|
|
|||
| function test_src_db_table_dropped_during_import() { | |||
There was a problem hiding this comment.
- table is dropped before src db sends any files -> dst db will not see src table and import will fail. This is tested in
test_source_table_does_not_exist - table is dropped after src db sends all files -> not worth testing: from the perspective of the dst db this is equivalent to the drop not happening
- table is dropped while src db sends files -> tested in
test_src_db_table_dropped_during_import.comdb2_filessends transaction log files after sending all btree files. So if the drop happens after btree files have been sent, then the import will error if the txn log reflecting the drop has been flushed to disk by the time it is sent to the src db and succeed if it hasn't (because the dst db brings up a copy of the src db with the files that it gets and runs recovery on it). Either of these outcomes is fine.
There was a problem hiding this comment.
Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 10/615 tests failed ⚠.
The first 10 failing tests are:
disttxn [setup failure]
cldeadlock
unionpar_maxqueue
reco-ddlk-sql
analyze
sc_lotsoftables_logicalsc_generated
sc_lotsoftables
insert_lots_ssl_generated
insert_lots_large_tran_generated
morgando
force-pushed
the
bulk_import_tests
branch
from
23f70d7 to
a8df219
Compare
There was a problem hiding this comment.
Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 10/616 tests failed ⚠.
The first 10 failing tests are:
socksql_master_swings
unionpar_maxqueue
phys_rep_tiered
bulkimport
sc_lotsoftables_logicalsc_generated
sc_lotsoftables
insert_lots_ssl_generated
insert_lots_large_tran_generated
selectv_rcode
cldeadlock
Signed-off-by: mdouglas47 <[email protected]>
morgando
force-pushed
the
bulk_import_tests
branch
from
a8df219 to
7e6492a
Compare
There was a problem hiding this comment.
Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 11/616 tests failed ⚠.
The first 10 failing tests are:
incremental_backup_usenames
ixentry_order
bulkimport
unionpar_maxqueue
phys_rep_tiered_firstfile_generated
sc_lotsoftables
reco-ddlk-sql
insert_lots_ssl_generated
insert_lots_large_tran_generated
insert_lots
