Disable logical logging for modsnap #5159
Conversation
Signed-off-by: mdouglas47 <[email protected]>
There was a problem hiding this comment.
Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 83/607 tests failed ⚠.
The first 10 failing tests are:
newsi_temptables [setup core dumped]
pglogs_seqnum [setup core dumped]
siconfig_orig_generated [setup core dumped]
siconfig_orig_after_newsi_generated [setup core dumped]
sc_timepart_logicalsc_generated
sc_timepart
fdb_compat
serialstep
selectv_recom_range
selectv_range
There was a problem hiding this comment.
Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Error ⚠.
Regression testing: 204/613 tests failed ⚠.
The first 10 failing tests are:
newsi_temptables [setup core dumped]
pglogs_seqnum [setup core dumped]
cldeadlock
sc_transactional_rowlocks_generated
comdb2sys
analyze
serialstep
selectv_recom_range
selectv_range
occ_selectv
Turning on modsnap turns on BDB_ATTR_SNAPISOL, which enables logical logging. Logical logging is not required for modsnap. The changes in this PR only turn on BDB_ATTR_SNAPISOL if the snapshot implementation is not modsnap or serializable is enabled.