change namespace and disable it by default #5000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/plugin-branch change_iam_namespace |
roborivers
suggested changes
Feb 4, 2025
There was a problem hiding this comment.
Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Error ⚠.
Regression testing: 2/596 tests failed ⚠.
The first 10 failing tests are:
tunables
incremental_backup_load
Signed-off-by: mohitkhullar <[email protected]>
mohitkhullar
force-pushed
the
change_iam_namespace
branch
from
742ee4c to
ce08c7b
Compare
roborivers
suggested changes
Feb 4, 2025
There was a problem hiding this comment.
Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Error ⚠.
Regression testing: 3/596 tests failed ⚠.
The first 10 failing tests are:
fdb_compat_rte_connect_generated
incremental_backup_load
cldeadlock
mponomar
approved these changes
Feb 5, 2025
|
Thanks |
markhannum
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change namespace and disable it by default
/plugin-branch change_iam_namespace