Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use op codes to form query plan instead of using query path #4963

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

chands10
Copy link
Contributor

To help us review your pull request, please consider providing an overview of the following:

  • What is the type of the change (bug fix, feature, documentation and etc.) ?
  • What are the current behavior and expected behavior, if this is a bugfix ?
  • What are the steps required to reproduce the bug, if this is a bugfix ?
  • What is the current behavior and new behavior, if this is a feature change or enhancement ?
  • [Optional] Why is the new behavior better than the current behavior, if this is a feature change ?

Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 6/595 tests failed ⚠.

The first 10 failing tests are:
occ_selectv [setup failure]
scindex_logicalsc_generated
scindex
recover_deadlock
incoherent_slow
simple_remsql_whitelist_generated

@chands10 chands10 force-pushed the query_plan_2 branch 2 times, most recently from 5a2bf69 to 84c9ba4 Compare January 16, 2025 19:10
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Error ⚠.
Regression testing: 0/0 tests failed ⚠.

Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 4/595 tests failed ⚠.

The first 10 failing tests are:
recover_deadlock
fdb_compat
scindex_logicalsc_generated
scindex

@chands10 chands10 marked this pull request as draft January 17, 2025 22:04
@chands10 chands10 marked this pull request as ready for review January 24, 2025 20:08
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 4/595 tests failed ⚠.

The first 10 failing tests are:
scindex_logicalsc_generated
scindex
recover_deadlock
disttxn

@chands10 chands10 marked this pull request as draft January 27, 2025 15:51
@chands10 chands10 marked this pull request as ready for review January 27, 2025 16:13
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 3/595 tests failed ⚠.

The first 10 failing tests are:
scindex_logicalsc_generated
scindex
recover_deadlock

Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 4/595 tests failed ⚠.

The first 10 failing tests are:
scindex_logicalsc_generated
scindex
recover_deadlock
comdb2sys_pagesize_generated

@chands10 chands10 marked this pull request as draft January 28, 2025 16:18
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 3/596 tests failed ⚠.

The first 10 failing tests are:
scindex
scindex_logicalsc_generated
recover_deadlock

Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 4/596 tests failed ⚠.

The first 10 failing tests are:
scindex
scindex_logicalsc_generated
recover_deadlock
sc_truncate

Signed-off-by: Salil Chandra <[email protected]>
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 4/596 tests failed ⚠.

The first 10 failing tests are:
scindex_logicalsc_generated
scindex
recover_deadlock
comdb2sys_pagesize_generated

Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 6/596 tests failed ⚠.

The first 10 failing tests are:
recover_deadlock
scindex
scindex_logicalsc_generated
triggersc_latency
incremental_backup_load
cldeadlock

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants