Add set statement to force fdb_push_redirect #4440
Conversation
There was a problem hiding this comment.
Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Error ⚠.
Regression testing: 7/534 tests failed ⚠.
The first 10 failing tests are:
sc_resume_logicalsc_generated
phys_rep_tiered_nosource_generated
phys_rep_tiered
truncatesc_offline_generated
comdb2sys_queueodh_generated
comdb2sys_pagesize_generated
comdb2sys
chands10
force-pushed
the
set_redirect
branch
2 times, most recently
from
84ffc34
to
26a14a6
Compare
There was a problem hiding this comment.
Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Error ⚠.
Regression testing: 14/534 tests failed ⚠.
The first 10 failing tests are:
lostwrite [setup failure]
cldeadlock
sirandtest
sc_resume_logicalsc_generated
schemalk_extralock_generated
schemalk
sc_transactional_rowlocks_generated
phys_rep_tiered
phys_rep_tiered_nosource_generated
truncatesc
chands10
force-pushed
the
set_redirect
branch
2 times, most recently
from
9d38ef5
to
35f246c
Compare
There was a problem hiding this comment.
Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 8/534 tests failed ⚠.
The first 10 failing tests are:
sc_timepart
schemalk_extralock_generated
phys_rep_tiered_nosource_generated
phys_rep_tiered
truncatesc_offline_generated
comdb2sys
comdb2sys_queueodh_generated
comdb2sys_pagesize_generated
db/dohast.c
Outdated
| @@ -955,7 +955,9 @@ int comdb2_check_push_remote(Parse *pParse) | |||
| ast_t *ast = pParse->ast; | |||
| dohsql_node_t *node; | |||
|
|
|||
| if (!gbl_fdb_push_remote) | |||
| struct sql_thread *thd = pthread_getspecific(query_info_key); | |||
There was a problem hiding this comment.
use the GET_CLNT macro ?
…orce one of these to be used, even if tunable is off Note that if fdb push redirect + remote tunables are on, but set force_fdb_push off is run, the tunable still takes precedence and runs with the option on Signed-off-by: Salil Chandra <[email protected]>
There was a problem hiding this comment.
Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 11/534 tests failed ⚠.
The first 10 failing tests are:
sc_resume_logicalsc_generated
sc_timepart
schemalk_extralock_generated
phys_rep_tiered_nosource_generated
phys_rep_tiered
union_parallel
truncatesc_offline_generated
truncatesc
comdb2sys_queueodh_generated
comdb2sys_pagesize_generated
Add option
set force_fdb_pushwith optionsredirect,remote,offto force one of these to be used, even if tunable is offNote that if fdb push redirect + remote tunables are on, but
set force_fdb_push offis run, the tunable still takes precedence and runs with the option on