Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use modsnap for snapshot in non-legacy configurations #4402

Closed
wants to merge 7 commits into from

Conversation

morgando
Copy link
Contributor

@morgando morgando commented May 3, 2024

The modsnap snapshot implementation is not enabled by default right now. The changes in this PR make it the default snapshot implementation while keeping it disabled in the legacy configuration.

There were some updates to tunables to make this work:

  1. The do_not_use_modsnap_for_snapshot tunable disables the modsnap implementation. This tunable is included in legacy_defaults
  2. The enable_snapshot_isolation tunable now enables the modsnap implementation if modsnap was not disabled with do_not_use_modsnap_for_snapshot. If modsnap was disabled, then it enables the fallback implementation.

Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lint check:

@@ db/db_tunables.h @@
+ Please update the tunable documentation (docs/pages/config/config_files.md) accordingly.

@morgando morgando marked this pull request as draft May 3, 2024 15:23
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 318/532 tests failed ⚠.

The first 10 failing tests are:
sirandtest
sc_resume_logicalsc_generated
sc_resume
schemalk
queuedb_rollover_noroll1_generated
queuedb_rollover
timepart_trunc
selectv_rcode_serialretry_generated
selectv_rcode
selectv_rcode_disable_svonly_nop_generated

@morgando morgando force-pushed the modsnap_for_open_source branch 2 times, most recently from 29fc73b to 9cf7cc4 Compare May 3, 2024 18:34
@morgando morgando marked this pull request as ready for review May 3, 2024 19:40
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lint check:

@@ db/db_tunables.h @@
+ Please update the tunable documentation (docs/pages/config/config_files.md) accordingly.

Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 12/532 tests failed ⚠.

The first 10 failing tests are:
sc_resume_logicalsc_generated
sc_timepart_logicalsc_generated
sc_resume
schemalk_logicalsc_generated
queuedb_rollover_noroll1_generated
queuedb_rollover
transchunk_manyins
sc_downgrade
truncatesc_offline_generated
comdb2sys_queueodh_generated

Signed-off-by: Morgan Douglas <[email protected]>
Signed-off-by: Morgan Douglas <[email protected]>
Signed-off-by: Morgan Douglas <[email protected]>
.
Signed-off-by: Morgan Douglas <[email protected]>
.
Signed-off-by: Morgan Douglas <[email protected]>
Signed-off-by: Morgan Douglas <[email protected]>

.

Signed-off-by: Morgan Douglas <[email protected]>
.
Signed-off-by: Morgan Douglas <[email protected]>
@morgando morgando closed this Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants