Use modsnap for snapshot in non-legacy configurations #4402
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The modsnap snapshot implementation is not enabled by default right now. The changes in this PR make it the default snapshot implementation while keeping it disabled in the legacy configuration.
There were some updates to tunables to make this work:
do_not_use_modsnap_for_snapshot
tunable disables the modsnap implementation. This tunable is included inlegacy_defaults
enable_snapshot_isolation
tunable now enables the modsnap implementation if modsnap was not disabled withdo_not_use_modsnap_for_snapshot
. If modsnap was disabled, then it enables the fallback implementation.