Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix partition rollout and remove scdone outside finalizing txn #4367

Closed

Conversation

dorinhogea
Copy link
Contributor

3 things:

  • avoid reading llmeta during views update (lock inversion prevention) (ported avoid lock inversion during partition rollout #4365 to main)
  • remove code and tunable sc_done_same_tran (only on going forward)
  • fix scdone for comdb2sc and partition rollouts, where it is sent outside finalizing txn

Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 374/528 tests failed ⚠.

The first 10 failing tests are:
simple_timepart_reptimeout_generated
timepart_changeretention
timepart_retention1
simple_timepart
sc_timepart_logicalsc_generated
sc_timepart
timepart_auth
renametable
renametable_lightweight_generated
timepart_readonly

@dorinhogea dorinhogea force-pushed the fix_lock_inversion_partitionsm branch from 373084f to 0536b84 Compare April 24, 2024 21:26
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 447/529 tests failed ⚠.

The first 10 failing tests are:
systable_locking
timepart_retention1
timepart_changeretention
simple_timepart_reptimeout_generated
simple_timepart
sc_timepart_logicalsc_generated
sc_resume_logicalsc_generated
sc_resume
sc_timepart
timepart_auth

Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Error ⚠.
Regression testing: 436/529 tests failed ⚠.

The first 10 failing tests are:
systable_locking
timepart_retention1
simple_timepart_reptimeout_generated
timepart_changeretention
simple_timepart
sc_timepart
sc_resume_logicalsc_generated
sc_timepart_logicalsc_generated
sc_resume
queuedb_rollover

@dorinhogea dorinhogea force-pushed the fix_lock_inversion_partitionsm branch from 0536b84 to 8238931 Compare April 29, 2024 20:46
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Error. ⚠.
Smoke testing: Error ⚠.
Cbuild submission: Error ⚠.
Regression testing: 0/0 tests failed ⚠.

Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Error. ⚠.
Smoke testing: Error ⚠.
Cbuild submission: Error ⚠.
Regression testing: 396/532 tests failed ⚠.

The first 10 failing tests are:
truncatesc
sc_resume_logicalsc_generated
sc_resume
queuedb_rollover_noroll1_generated
timepart_auth
timepart_changeretention
renametable_lightweight_generated
renametable
timepart_readonly
timepart_constraints

@dorinhogea dorinhogea force-pushed the fix_lock_inversion_partitionsm branch from 8238931 to 9674505 Compare April 30, 2024 13:42
@dorinhogea dorinhogea added the WIP Work in Progress label May 1, 2024
@dorinhogea dorinhogea force-pushed the fix_lock_inversion_partitionsm branch from 9674505 to 99cda01 Compare May 7, 2024 18:32
@dorinhogea dorinhogea removed the WIP Work in Progress label May 7, 2024
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 5/532 tests failed ⚠.

The first 10 failing tests are:
schemalk_logicalsc_generated
sc_transactional_rowlocks_generated
timepart_trunc
comdb2sys_queueodh_generated
truncatesc_offline_generated

@dorinhogea dorinhogea force-pushed the fix_lock_inversion_partitionsm branch 2 times, most recently from d8e9572 to 2e81e41 Compare May 8, 2024 14:44
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 396/532 tests failed ⚠.

The first 10 failing tests are:
replay_history
truncatesc
sc_resume_logicalsc_generated
sc_resume
timepart_auth
timepart_changeretention
renametable_lightweight_generated
renametable
timepart_readonly
timepart_constraints

Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Error. ⚠.
Smoke testing: Error ⚠.
Cbuild submission: Success ✓.
Regression testing: 0/0 tests failed ⚠.

@dorinhogea dorinhogea force-pushed the fix_lock_inversion_partitionsm branch from 2e81e41 to 99cda01 Compare May 13, 2024 14:14
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Error. ⚠.
Smoke testing: Error ⚠.
Cbuild submission: Success ✓.
Regression testing: 0/0 tests failed ⚠.

@dorinhogea dorinhogea force-pushed the fix_lock_inversion_partitionsm branch from 99cda01 to fc95886 Compare May 17, 2024 19:09
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Error. ⚠.
Smoke testing: Error ⚠.
Cbuild submission: Error ⚠.
Regression testing: 0/0 tests failed ⚠.

Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Error. ⚠.
Smoke testing: Error ⚠.
Cbuild submission: Error ⚠.
Regression testing: 0/0 tests failed ⚠.

avoid reading llmeta during views update (lock inversion prevention)
remove code and tunable sc_done_same_tran (only on going forward)
fix scdone for comdb2sc and partition rollouts, where it is sent outside finalizing txn

Signed-off-by: Dorin Hogea <[email protected]>
@dorinhogea dorinhogea force-pushed the fix_lock_inversion_partitionsm branch from fc95886 to f3fc827 Compare May 20, 2024 14:52
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 9/534 tests failed ⚠.

The first 10 failing tests are:
sc_resume
schemalk_extralock_generated
schemalk
phys_rep_tiered_nosource_generated
phys_rep_tiered
transchunk_manyins
comdb2sys
sc_downgrade
truncatesc_offline_generated

@dorinhogea
Copy link
Contributor Author

resubmitted with shorted name because it breaks robom (#4457)

@dorinhogea dorinhogea closed this May 28, 2024
@dorinhogea dorinhogea deleted the fix_lock_inversion_partitionsm branch May 28, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants