-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix partition rollout and remove scdone outside finalizing txn #4367
fix partition rollout and remove scdone outside finalizing txn #4367
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 374/528 tests failed ⚠.
The first 10 failing tests are:
simple_timepart_reptimeout_generated
timepart_changeretention
timepart_retention1
simple_timepart
sc_timepart_logicalsc_generated
sc_timepart
timepart_auth
renametable
renametable_lightweight_generated
timepart_readonly
373084f
to
0536b84
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 447/529 tests failed ⚠.
The first 10 failing tests are:
systable_locking
timepart_retention1
timepart_changeretention
simple_timepart_reptimeout_generated
simple_timepart
sc_timepart_logicalsc_generated
sc_resume_logicalsc_generated
sc_resume
sc_timepart
timepart_auth
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Error ⚠.
Regression testing: 436/529 tests failed ⚠.
The first 10 failing tests are:
systable_locking
timepart_retention1
simple_timepart_reptimeout_generated
timepart_changeretention
simple_timepart
sc_timepart
sc_resume_logicalsc_generated
sc_timepart_logicalsc_generated
sc_resume
queuedb_rollover
0536b84
to
8238931
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coding style check: Error. ⚠.
Smoke testing: Error ⚠.
Cbuild submission: Error ⚠.
Regression testing: 0/0 tests failed ⚠.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coding style check: Error. ⚠.
Smoke testing: Error ⚠.
Cbuild submission: Error ⚠.
Regression testing: 396/532 tests failed ⚠.
The first 10 failing tests are:
truncatesc
sc_resume_logicalsc_generated
sc_resume
queuedb_rollover_noroll1_generated
timepart_auth
timepart_changeretention
renametable_lightweight_generated
renametable
timepart_readonly
timepart_constraints
8238931
to
9674505
Compare
9674505
to
99cda01
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 5/532 tests failed ⚠.
The first 10 failing tests are:
schemalk_logicalsc_generated
sc_transactional_rowlocks_generated
timepart_trunc
comdb2sys_queueodh_generated
truncatesc_offline_generated
d8e9572
to
2e81e41
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 396/532 tests failed ⚠.
The first 10 failing tests are:
replay_history
truncatesc
sc_resume_logicalsc_generated
sc_resume
timepart_auth
timepart_changeretention
renametable_lightweight_generated
renametable
timepart_readonly
timepart_constraints
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coding style check: Error. ⚠.
Smoke testing: Error ⚠.
Cbuild submission: Success ✓.
Regression testing: 0/0 tests failed ⚠.
2e81e41
to
99cda01
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coding style check: Error. ⚠.
Smoke testing: Error ⚠.
Cbuild submission: Success ✓.
Regression testing: 0/0 tests failed ⚠.
99cda01
to
fc95886
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coding style check: Error. ⚠.
Smoke testing: Error ⚠.
Cbuild submission: Error ⚠.
Regression testing: 0/0 tests failed ⚠.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coding style check: Error. ⚠.
Smoke testing: Error ⚠.
Cbuild submission: Error ⚠.
Regression testing: 0/0 tests failed ⚠.
avoid reading llmeta during views update (lock inversion prevention) remove code and tunable sc_done_same_tran (only on going forward) fix scdone for comdb2sc and partition rollouts, where it is sent outside finalizing txn Signed-off-by: Dorin Hogea <[email protected]>
fc95886
to
f3fc827
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 9/534 tests failed ⚠.
The first 10 failing tests are:
sc_resume
schemalk_extralock_generated
schemalk
phys_rep_tiered_nosource_generated
phys_rep_tiered
transchunk_manyins
comdb2sys
sc_downgrade
truncatesc_offline_generated
resubmitted with shorted name because it breaks robom (#4457) |
3 things: