Skip to content

Dev simple spend #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
quentinlesceller merged 7 commits into from
Jul 27, 2023
Merged

Dev simple spend #129

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
81d2d37
modified the simple_spend to support flexible fees
Jul 22, 2023
34365c0
updated default simple_spend fees value
Jul 22, 2023
1eac1e6
added test for update to simple_spend
Jul 22, 2023
c30f2d7
Merge branch 'master' into dev_simple_spend
quentinlesceller Jul 27, 2023
ab2e9b9
updated preference default for simple_spend and simple_spend_p2sh
Jul 27, 2023
e23cff2
updated test for simple_spend
Jul 27, 2023
e094577
updated simple_spend and simple_spend_p2sh fees preference values
Jul 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,3 +47,4 @@ coverage.xml
# Django stuff:
*.log
*.pot
.idea/
6 changes: 5 additions & 1 deletion blockcypher/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1624,7 +1624,7 @@ def broadcast_signed_transaction(unsigned_tx, signatures, pubkeys, coin_symbol='


def simple_spend(from_privkey, to_address, to_satoshis, change_address=None,
privkey_is_compressed=True, min_confirmations=0, api_key=None, coin_symbol='btc'):
privkey_is_compressed=True, min_confirmations=0, api_key=None, coin_symbol='btc', preference: str = 'low'):
Copy link
Contributor

@quentinlesceller quentinlesceller Jul 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For a better UX I suggest that keep the fee high here.

Copy link
Contributor Author

@frier17 frier17 Jul 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your feedback @quentinlesceller. I plan making the needed changes. Also noticed a similar need for the function simple_spend_p2sh. Will attempt to make similar changes and add tests as well.

Thanks

'''
Simple method to spend from one single-key address to another.

Expand All @@ -1640,6 +1640,9 @@ def simple_spend(from_privkey, to_address, to_satoshis, change_address=None,
Compressed public keys (and their corresponding addresses) have been the standard since v0.6,
set privkey_is_compressed=False if using uncompressed addresses.

Fees preferences can be set as strings with value 'low', 'medium', 'zero' or 'high'.
Transaction with zero fees are unlikely to be added to a block. This value was

Note that this currently only supports spending from single key addresses.
'''
assert is_valid_coin_symbol(coin_symbol), coin_symbol
Expand Down Expand Up @@ -1673,6 +1676,7 @@ def simple_spend(from_privkey, to_address, to_satoshis, change_address=None,
verify_tosigntx=False, # will verify in next step
include_tosigntx=True,
api_key=api_key,
preference=preference if preference in ('high', 'medium', 'low', 'zero') else 'high'
)
logger.info('unsigned_tx: %s' % unsigned_tx)

Expand Down
Loading