This repository has been archived by the owner on Mar 7, 2023. It is now read-only.
Dgld 2 #3
Open
Dgld 2 #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 15 commits
May 4, 2020 15:48
Makefiles fixed. Unit tests passing.
Package version updates.
pavel-bc
reviewed
May 14, 2020
| val expected = AnyAddress("__EXPECTED_RESULT_ADDRESS__", CoinType.DIGITALGOLD) | ||
|
|
||
| assertEquals(pubkey.data().toHex(), "0x__EXPECTED_PUBKEY_DATA__") | ||
| assertEquals(address.description(), expected.description()) |
There was a problem hiding this comment.
Are you planning to add test cases here? Seems like you already have one working on C++ core level
pavel-bc
reviewed
May 14, 2020
| //assertEquals( | ||
| // "__EXPECTED_RESULT_DATA__", | ||
| // Numeric.toHexString(output.encoded.toByteArray()) | ||
| //) |
pavel-bc
reviewed
May 14, 2020
| let addressFromString = AnyAddress(string: "__ADDRESS_DATA__", coin: .digitalgold)! | ||
|
|
||
| XCTAssertEqual(pubkey.data.hexString, "__EXPECTED_PUBKEY_DATA__") | ||
| XCTAssertEqual(address.description, addressFromString.description) |
pavel-bc
reviewed
May 14, 2020
| memset(ed25519_public_key_val, 0, 32); | ||
| curve25519_pk_to_ed25519(ed25519_public_key_val, node->public_key + 1); | ||
| ed25519_sign(msg, msg_len, node->private_key, ed25519_public_key_val, sig); | ||
| const uint8_t sign_bit = ed25519_public_key_val[31] & 0x80; |
There was a problem hiding this comment.
Seems like a leftover from debugging? (Because it's just variable rename)
We don't want to change the core very much, unless it's really necessary
pavel-bc
reviewed
May 14, 2020
| @@ -118,7 +119,7 @@ Data Base58::decode(const char* begin, const char* end) const { | |||
| } | |||
|
|
|||
| // Skip trailing spaces. | |||
| it = std::find_if_not(it, end, std::isspace); | |||
| it = std::find_if_not(it, end, [](unsigned char ch) -> bool { return std::isspace(ch); }); | |||
There was a problem hiding this comment.
Is it a new requirement enforced by altered build flags?
I still see the old lines in upstream master - https://github.com/trustwallet/wallet-core/blob/master/src/Base58.cpp#L80
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
DGLD implementation.
Testing instructions
Tests will be executed during build.
Types of changes
Rebased to new master.
Test cases, notably signing.
Some build system fixes.