Feature/spinner control #213
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spinner granularity can be set to 5, 10, or 15 seconds in the preferences now. If a time value is entered for an exercise that cannot be shown in the spinner, then it will automatically show the text edit instead of the spinner. Changing the value to a valid spinner value will call the spinner to reappear.
This is optional functionality that you have to enable the pref to get. Once it is set, you have to tap on a spinner to get it to activate. The spinner will automatically deactivate when the user stops scrolling. When the pref is turned off, the behavior should be exactly as it is now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a preference for Spinner granularity which can be set to 5, 10, or 15 seconds.
If a time value is entered for an exercise that cannot be shown in the spinner, then it will automatically show the text edit instead of the spinner. Changing the value to a valid spinner value will call the spinner to reappear. This addresses bug
#197
Add a preference for tap to edit. When it is activated, spinners have to be tapped to cause them to work instead of always being active. you can also long press to enter the manual text edit mode.