Skip to content

Category Tree #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Category Tree #103

wants to merge 13 commits into from

Conversation

ynzenu
Copy link

@ynzenu ynzenu commented Mar 6, 2025

Category Tree

Designed to help users find pathing categories.

I think it would be good to do a pre-release before doing a public release in order to monitor for any bugs/issues.

General

  • Greyed out text means the category is inactive and any child markers/trails are not rendered.
  • Enabling/disabling categories in the context menu are synced to the category tree (UI Sync between the two).
  • Most functionality is the same as in the context menu, such as when toggling "All Markers" the markers will be globally disabled via a setting.
  • The "X hidden (click to show)" button is only displayed when "Indicate When Categories Are Hidden" is enabled in the settings.

Achievements

  • Checkmark means the achievement is been completed, but only if "Allow Markers to Automatically Hide" is enabled in the settings.
  • Category only displays a tooltip if "Show Tooltips for Achievements" is enabled in the settings.

Path navigation

There are 3 ways to quickly navigate to a category in the tree:

  • Right click on the category in the tree and select "Copy Path". This path can then be inserted in the search box.
  • Right clicking on a marker on the map or mini map will display the "Open Parent Category" option. Clicking this will open the Category Tree and automatically navigate to the parent category of the selected marker.
  • Right click on the category in the search results and select "Open In Category Tree".

Icons

The entity textures are displayed side by side as can be seen in this example where the entities underneath the categories have 5 different textures:

Missing

  • Manifest has not been updated yet with a new version.
  • "Truncate category name" setting is not used in the category tree)
  • Localization - There is already localization missing in multiple places, so I thought this is something to add in another PR.

Discussion Reference

https://discord.com/channels/531175899588984842/958231812780474409/1342005038624542731

Related Github issues

#99 [Suggestion] Quick action : show markers parent category in main menu ?
#90 Enhanced Marker UI
#43 Search for categories

Is this a breaking change?

No, I don't think so.

@ynzenu ynzenu changed the title Feature/marker tree 2 Category Tree Mar 6, 2025
ReflowChildLayout(ChildBaseNodes);
} catch (Exception ex) {
//Investigate why collection is sometimes modified during reflow
_logger.Info($"Could not recalculate TreeView layout: {ex.Message}");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this an INFO?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've now changed it to be a warning.

It's not critical error, and it seems to be quite rare, which is why I haven't fully investigated it yet.

@ynzenu
Copy link
Author

ynzenu commented Mar 24, 2025

I've made a few small tweaks and fixes:

  • Fixed an issue that caused the 'X hidden (click to show)' number to be incorrect
  • Fixed an issue that would create ghost categories when pasting paths
  • Removed the 'Copy Display Name' option because it was a duplicate of 'Copy Name'

UI

  • Added 2 labels for when the packs are not initialized (when you are in the character screen and haven't joined the game yet) and no packs are loaded (unchecked 'always load' or no packs installed).

@ynzenu
Copy link
Author

ynzenu commented Apr 15, 2025

Fixed the following:

  • Swapped the right click options on the map and mini map (Open Parent Category is now before Hide Parent Category)
  • Icon tooltip is now not displayed for the separator and 'click to show more' nodes.
  • Tooltip textures are automatically resized to 200x200 if they are larger than that size.
  • Fixed issue where the right-click option "Open in category tree" was not available for sub-nodes in the search results.

Example of map right-click options:
image

Examples of the tooltips with large images:
Screenshot 2025-04-15 152804
Screenshot 2025-04-15 152731

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants