Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Rename RISC-V machine scratch CSR #2043

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

ALTracer
Copy link
Contributor

@ALTracer ALTracer commented Jan 7, 2025

Detailed description

  • This is a small typo fix.
  • The existing problem is tscratch description for gdb target.xml of MSCRATCH CSR.
  • The PR solves it by renaming to mscratch.

Not tested on anything, because I don't have a gd32vf1/sipeed longan nano, and ESP32-C3 needs burning OTP eFuses for external JTAG (USJ is not supported by BMDA). Unsure what uses this.

Your checklist for this pull request

Closing issues

@dragonmux dragonmux added this to the v2.0 release milestone Jan 7, 2025
@dragonmux dragonmux added the Bug Confirmed bug label Jan 7, 2025
Copy link
Member

@dragonmux dragonmux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM - merging. Thanks for the contribution!

@ALTracer ALTracer force-pushed the fix/riscv-mscratch branch from 48c646c to bf1934e Compare January 7, 2025 15:23
@dragonmux dragonmux merged commit bf1934e into blackmagic-debug:main Jan 7, 2025
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Confirmed bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants