allow any input type #16
Conversation
src/st_keyup/frontend/main.js
Outdated
| } | ||
| else { | ||
| input.type = "text" | ||
| input.type = type |
There was a problem hiding this comment.
Are there particular other types you would like to support? I certainly don't want people passing type=radio, as that wouldn't make too much sense.
There was a problem hiding this comment.
Good point, the other input types I wanted to add were: "tel", "number" & "email".
There was a problem hiding this comment.
That sounds good -- would you mind updating this to explicitly allow that set of options, and update the python code to document what types are allowed?
There was a problem hiding this comment.
I've updated the doc string, and changed the css to support darkmode 😊
|
This is great overall! Can you please fix the linting issues? (You can do this with pre-commit install and then pre-commit run --all-files) Also, is there a reason you changed some of the sizes in CSS? Could you change those back, so that it lines up better with existing streamlit widgets? My goal was for this to look as identical as possible to st.text_input |
changed it such that it allows any input type to be set.