Skip to content

Forecast dates always assume daily input data regardless of the actual input data frequency #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
huddlej opened this issue May 16, 2025 · 0 comments · May be fixed by #54
Open

Forecast dates always assume daily input data regardless of the actual input data frequency #53

huddlej opened this issue May 16, 2025 · 0 comments · May be fixed by #54
Assignees

Comments

@huddlej
Copy link

huddlej commented May 16, 2025

Problem

We run the MLR model on sequence counts aggregated at 14-day intervals, the step size of the model’s time scale is 14 days instead of 1 day.

When we forecast future frequencies to L steps into the future, those should be on the same time scale of 14-day steps, but the forecast dates exported to the model JSON occur at 1-day steps.

Proposed solution

To get the appropriate forecast dates from evofr, we could modify the forecast_dates function to infer the duration of time between steps from the observed dates passed as the first input to that function and use that duration instead of 1 day to generate the forecast dates

@huddlej huddlej self-assigned this May 16, 2025
@huddlej huddlej linked a pull request May 16, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant