Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to imgui IO event API #2726

Merged
merged 1 commit into from Feb 11, 2022
Merged

Switch to imgui IO event API #2726

merged 1 commit into from Feb 11, 2022

Conversation

pezcode
Copy link
Contributor

@pezcode pezcode commented Feb 11, 2022

Imgui 1.87 added new functions for registering mouse and key events, obsoleting directly writing to structures in ImGuiIO.

For more information see ocornut/imgui#4921.

@pezcode
Switch to imgui IO event API
b3c3bbe 
Added in imgui 1.87
@bkaradzic bkaradzic merged commit 88a6317 into bkaradzic:master Feb 11, 2022
@bkaradzic
Copy link
Owner

Any reason why you doing this (int)enum casting? There is no typed enums in code base.

I just removed casts:
8f96b8a

@pezcode
Copy link
Contributor Author

pezcode commented Feb 11, 2022

Any reason why you doing this (int)enum casting? There is no typed enums in code base.

Previous code had explicit cast to int, I figured this might be some compiler warning thing and kept it. Good to know it works without 👍

mipek pushed a commit to mipek/bgfx that referenced this pull request Mar 2, 2024
@pezcode
Switch to imgui IO event API (bkaradzic#2726)
ca23cfc 
Added in imgui 1.87
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkaradzic bkaradzic Awaiting requested review from bkaradzic bkaradzic is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pezcode @bkaradzic