Add CompositeSubscription #42
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nforce single-unsubscribe policy, and auto-unsubscribe new subscriptions when unsubscribed.
|
Note: my attempt to fix issue-22 currently utilizes the code in this PR. Managing multiple related subscriptions is tricky, and this helps a lot. |
|
Hi, I don't know if you're still interested in this, but I'm now maintaining my own fork of this library and actually it does have a built-in mechanism for creation of compose composite subscriptions like in RxJS directly via |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add CompositeSubscription, a helper class for managing multiple Subscriptions and easily unsubscribing them all.
This is based on CompositeSubscription from RxJava 1. Its addition is not strictly necessary, but I've found it to be quite helpful in my own applications and figured others might find it useful as well. It's up to the maintainers to decide whether or not this is an appropriate addition to RxLua.
This pull request also moves
subscription.luaandcompositesubscription.luato a newsrc/subscriptionssubdirectory. I was unsure whether or not it was appropriate to put CompositeSubscription in the root src directory or if it should live in a specialized subdirectory like schedulers, subjects, and operators do.