Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

96 ensure defaults in env vars #98

Merged
merged 4 commits into from
Apr 17, 2020
Merged

96 ensure defaults in env vars #98

merged 4 commits into from
Apr 17, 2020

Conversation

jac1013
Copy link
Member

@jac1013 jac1013 commented Apr 3, 2020

Description

Ensure env vars defaults when we can.

Stories

#96

List of changes

  • Added some defaults.
  • Improved log messages when some env variables that are required are not present.

@jac1013 jac1013 requested a review from jonathancod April 3, 2020 22:12
@jac1013 jac1013 requested a review from soft4good April 17, 2020 21:06
@sonarcloud
Copy link

sonarcloud bot commented Apr 17, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jac1013 jac1013 merged commit 9c731a5 into master Apr 17, 2020
@jac1013 jac1013 deleted the 96-ensure-defaults-in-env-vars branch April 17, 2020 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soft4good soft4good soft4good approved these changes

@jonathancod jonathancod Awaiting requested review from jonathancod

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jac1013 @soft4good