Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for RELEASES URLs not containing the app name when using Nuts as an Express middleware #8

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

biw
Copy link
Owner

@biw biw commented Mar 17, 2021

When search parameters are present in the URL that Electron sends to Nuts:
For example:
http://localhost:4000/myApp/update/win32/1.0.0/RELEASES?arch=amd64

The app name is being omitted:
http://localhost:4000/download/1.1.0/my-app-1.1.0-full.nupkg

Expected Result:
http://localhost:4000/myApp/download/1.1.0/my-app-1.1.0-full.nupkg

resolves #150

From GitbookIO/nuts#159

@biw biw changed the title Strip down search params before parsing URL Fix for RELEASES URLs not containing the app name when using Nuts as an Express middleware Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants