Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-7682] Add Explicit Reference to Microsoft.AspNetCore.DataProtection #4010

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

justindbaur
Copy link
Member

Type of change

- [ ] Bug fix
- [ ] New feature development
- [x] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Without this explicit reference the next most explicit reference to a version was Azure.Extensions.AspNetCore.DataProtection.Blobs which won out and brought along with it version 3.1.32 instead.

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • If making database changes - make sure you also update Entity Framework queries and/or migrations
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

Copy link

codecov bot commented Apr 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.77%. Comparing base (3c76f48) to head (13b32bc).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4010   +/-   ##
=======================================
  Coverage   37.77%   37.77%           
=======================================
  Files        1188     1188           
  Lines       57879    57879           
  Branches     5539     5539           
=======================================
  Hits        21861    21861           
- Misses      34990    34991    +1     
+ Partials     1028     1027    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justindbaur justindbaur changed the title Add Explicit Reference to Microsoft.AspNetCore.DataProtection [PM-7682] Add Explicit Reference to Microsoft.AspNetCore.DataProtection Apr 23, 2024
Copy link
Contributor

github-actions bot commented Apr 23, 2024

Logo
Checkmarx One – Scan Summary & Details6ae720b0-935c-4252-bae0-1ac4a02c1cf7

No New Or Fixed Issues Found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant