Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-7886] Show either card number or security code and not both #3212

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

GobinathAL
Copy link

@GobinathAL GobinathAL commented May 2, 2024

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Enhancing security by implementing a feature to hide the CVV (Card Verification Value) when displaying the card number and vice versa. This enhancement aims to mitigate the risk of unauthorized access to sensitive financial information and aligns with industry best practices for safeguarding user data.

Code changes

src/Core/Pages/Vault/CipherDetailsPageViewModel.cs

Modified ToggleCardNumber and ToggleCardCode methods

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

@GobinathAL GobinathAL requested a review from a team as a code owner May 2, 2024 17:48
@CLAassistant
Copy link

CLAassistant commented May 2, 2024

CLA assistant check
All committers have signed the CLA.

@bitwarden-bot
Copy link

Thank you for your contribution! We've added this to our internal Community PR board for review.
ID: PM-7886

@bitwarden-bot bitwarden-bot changed the title Show either card number or security code and not both [PM-7886] Show either card number or security code and not both May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants