Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-4327] Adjust LaunchMode of WebAuth & Autofill helper activities #2824

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

mpbw2
Copy link
Contributor

@mpbw2 mpbw2 commented Oct 13, 2023

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Updated the LaunchMode of helper public activities (exported or having intent-filters) to restrict access in older versions of Android

Code changes

  • AutofillExternalSelectionActivity.cs: Add explicit export declaration
  • WebAuthCallbackActivity.cs: Moved declaration to the manifest and changed launch mode to SingleInstance based on Android API level.

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

@mpbw2 mpbw2 requested a review from a team October 13, 2023 20:16
@bitwarden-bot
Copy link

bitwarden-bot commented Oct 13, 2023

Logo
Checkmarx One – Scan Summary & Detailsfb98df5b-6149-44f4-bfdb-8f0a7cba5b7d

No New Or Fixed Issues Found

@mpbw2 mpbw2 added the needs-qa label Oct 13, 2023
fedemkr
fedemkr previously approved these changes Oct 17, 2023
# Conflicts:
#	src/App/Platforms/Android/Autofill/AutofillExternalSelectionActivity.cs
@github-actions github-actions bot removed the android label May 6, 2024
@fedemkr fedemkr requested a review from a team May 6, 2024 15:29
…ues only on WebAuthCallbackActivity given that it's exported and go back to previous value on the other ones. This is being done in the manifest so we can set the appropriate value depending on the API level.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants