Skip to content

doc fix signature for 8-bit optim #1660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 11, 2025

Conversation

ved1beta
Copy link
Contributor

Fixes #1216 i took the first approach by removing the args let me know if any changes are needed

@matthewdouglas
Copy link
Member

I'm not sure it's best to remove these arguments at the moment. Since it's designed to be a drop-in equivalent to PyTorch's implementation we should keep the same signature and consider raising if an unsupported argument is specified.

@matthewdouglas matthewdouglas added the Optimizers Issues or feature requests relating to optimizers label May 28, 2025
@matthewdouglas matthewdouglas self-requested a review May 28, 2025 16:16
@matthewdouglas matthewdouglas added this to the v0.47.0 milestone May 28, 2025
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@matthewdouglas matthewdouglas merged commit 61db085 into bitsandbytes-foundation:main Jun 11, 2025
41 checks passed
@matthewdouglas
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Optimizers Issues or feature requests relating to optimizers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants