Skip to content

Restyle seekbar chapter markers #698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: feature/modern-ui-base
Choose a base branch
from
Open

Restyle seekbar chapter markers #698

wants to merge 5 commits into from

Conversation

Andr3wid
Copy link
Contributor

@Andr3wid Andr3wid commented Apr 22, 2025 •
edited
Loading

Description

Apply styles to seekbar chapter markers to match the new v4 UI design.

Before:
image

After:
image

Checklist (for PR submitter and reviewers)

  • CHANGELOG entry

@Andr3wid Andr3wid self-assigned this Apr 22, 2025
@Andr3wid Andr3wid changed the title Restyle seekbar chapter markers Restyle seekbar and chapter markers Apr 22, 2025
@Andr3wid Andr3wid changed the title Restyle seekbar and chapter markers Restyle seekbar chapter markers Apr 22, 2025
@Andr3wid Andr3wid marked this pull request as ready for review April 22, 2025 09:54
@Andr3wid Andr3wid requested a review from bitmovin-kenny April 25, 2025 11:05
bitmovin-kenny
bitmovin-kenny reviewed Apr 28, 2025
View reviewed changes
Copy link
Contributor

@bitmovin-kenny bitmovin-kenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, not sure about the color of the range though since it masks the buffer level.

bitmovin-kenny
bitmovin-kenny approved these changes May 6, 2025
View reviewed changes
Copy link
Contributor

@bitmovin-kenny bitmovin-kenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would still like some opacity on the region marker in order for the buffer indicator to still be visible, but since this is the way it currently is ... 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bitmovin-kenny bitmovin-kenny bitmovin-kenny approved these changes

Assignees

@Andr3wid Andr3wid

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Andr3wid @bitmovin-kenny