Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rune transaction creation method #19

Merged
merged 6 commits into from
Apr 16, 2024
Merged

Conversation

Maximkaaa
Copy link
Contributor

@Maximkaaa Maximkaaa commented Apr 5, 2024

Motivation

Add methods to create and sign rune edict transactions.

Closes EPROD-813 (https://infinityswap.atlassian.net/browse/EPROD-813)

Changes

Test Plan

TODO

  • Explain motivation or link existing issue(s)
  • Test changes and document test plan
  • Update documentation as needed

DevOps Notes

  • This PR does not require configuration changes (e.g., environment variables, GitHub secrets, VM resources)
  • This PR does not affect public APIs
  • This PR does not rely on a new version of external services
  • This PR does not make changes to log messages (which monitoring infrastructure may rely on)

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.

Copy link
Member

@veeso veeso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have a unit test as it's been done for brc20 just to check if the inscription flow works?

Cargo.toml Outdated Show resolved Hide resolved
@Maximkaaa Maximkaaa force-pushed the maxim/rune_transactions branch from 02722da to 7ebcf94 Compare April 16, 2024 03:32
@Maximkaaa
Copy link
Contributor Author

Hey, @veeso , I've added the test for runes. The only issue there is that the fee estimation seems to work incorrectly (although, not by much). Since this is somewhat unrelated issue to the runes edict transaction creation, and is not critical for actual usage of the code in bridge canister (since it will not use taproot inputs for now), I created a separate ticket for this: https://infinityswap.atlassian.net/browse/EPROD-830 .

@Maximkaaa Maximkaaa requested a review from veeso April 16, 2024 03:38
@Maximkaaa Maximkaaa merged commit 5518bfe into main Apr 16, 2024
6 checks passed
@Maximkaaa Maximkaaa deleted the maxim/rune_transactions branch April 16, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants