Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix/expose fee estimations #16

Closed
wants to merge 10 commits into from
Closed

fix/expose fee estimations #16

wants to merge 10 commits into from

Conversation

veeso
Copy link
Member

@veeso veeso commented Mar 29, 2024

  • Move commit and reveal fees out of CreateCommitTransactionArgs
  • Export new types
  • Clean up
  • Fix external ECDSA signature verification
  • Bug fix
  • Properly handle signature encoding and decoding
  • Refactor transaction signing flow for external signer
  • External signing API works!
  • Introduce a new version of commit_tx builder with fixed fees for tests and examples
  • fix: expose fee estimation functions

@veeso veeso closed this Mar 29, 2024
@kobby-pentangeli kobby-pentangeli deleted the fix/expose-fee-estimations branch April 19, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@veeso @kobby-pentangeli