-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Gradle wrapper to Gradle 8.14 (milestone 5) #129
Conversation
24fc5ed
to
664ce06
Compare
# Conflicts: # gradle/wrapper/gradle-wrapper.properties
664ce06
to
23e5bfa
Compare
I'm ready to merge this PR to The next release of secp-jdk will be v0.2 and Gradle 8.14 will almost certainly be final before then. So, given that the risk is low, that this project is still pre-alpha, and we can always back it out if we really need to, I think it is reasonable to use this (5th) milestone release of Gradle on I also plan to submit PRs as soon as RC builds of Gradle 8.14 are available. Sound OK @schildbach and @craigraw ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What I usually do in such cases is keep the commit as part of the experimental branches. Git makes this super easy to manage (rebase, cherry-pick, etc). Using a pre-release of Gradle bears the risk of regression, which can affect all devs, also those not running experiments with Java 24.
I leave the decision up to you. The PR itself looks good.
Good point, and I would normally do this.
Since this is only the wrapper, it will only affect builds of this project for those using the wrapper.
I feel the risks of regression is fairly low and I'd like to move towards JDK 24 ASAP -- for the build and examples (but not the libraries) and JDK 25 as soon as it is ready. We can stabilize on 25. I'm hoping (with little knowledge of the details) that the JEP 484: Class-File APIwill make it easier for Gradle to support new JDK releases. I'm going to go merge it and keep my fingers crossed -- I think we'll be fine. |
No description provided.