Skip to content

ci: automated update to rustc 1.87.0 #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

create-pr-actions[bot]
Copy link

Automated update to Github CI workflow cont_integration.yml by create-pull-request GitHub action

@coveralls
Copy link

coveralls commented May 25, 2025

Pull Request Test Coverage Report for Build 15657929364

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 85.55%

Totals Coverage Status
Change from base Build 15476130196: 0.0%
Covered Lines: 7377
Relevant Lines: 8623

💛 - Coveralls

@notmandatory notmandatory self-assigned this May 25, 2025
@notmandatory notmandatory added the chore Non-coding related work label May 25, 2025
@notmandatory notmandatory moved this to In Progress in BDK Wallet May 25, 2025
@notmandatory notmandatory added this to the Wallet 2.0.0 milestone May 25, 2025
@notmandatory
Copy link
Member

notmandatory commented May 26, 2025

The main clippy error I had to fix was: result_large_err

Because I had to change the error enums to box large types I believe this becomes an API breaking change. Should we loosen the allowed enum size and fix the result_large_error clippy errors in the 3.0 milestone or fix this now?

I also added a Justfile to help run cargo clippy and cargo test with and without the MSRV.

The required CI tasks will also need to be updated from 1.85.0 to 1.87.0 before any version of this PR can be merged.

@notmandatory notmandatory added the api A breaking API change label May 26, 2025
@notmandatory notmandatory force-pushed the create-pull-request/update-rust-version branch from 5dbf554 to a2377f3 Compare May 27, 2025 02:13
@notmandatory
Copy link
Member

I updated the clippy.toml config to allow the larger enum and error types for now and created #245 for the larger fix.

@notmandatory notmandatory moved this from In Progress to Needs Review in BDK Wallet May 27, 2025
Copy link
Contributor

@oleonardolima oleonardolima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cACK a2377f3

Copy link
Contributor

@oleonardolima oleonardolima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK a2377f3

Copy link
Collaborator

@ValuedMammal ValuedMammal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK a2377f3

@create-pr-actions create-pr-actions bot force-pushed the create-pull-request/update-rust-version branch from a2377f3 to b8f331d Compare June 15, 2025 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api A breaking API change chore Non-coding related work
Projects
Status: Needs Review
Development

Successfully merging this pull request may close these issues.

4 participants