Skip to content

Drop Python 3.8 and 3.9 support #780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 16, 2025
Merged

Conversation

rustaceanrob
Copy link
Collaborator

Python 3.9 is 5 years old. The CI builds the Python binary for every platform and every version from 3.8-latest, but hasn't caught a significant issue.

Motivated by #769

Changelog notice

  • CI no longer builds for Python 3.8 and 3.9

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

Copy link
Collaborator

@ItoroD ItoroD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 5939076

@reez
Copy link
Collaborator

reez commented Jun 11, 2025

Makes sense, talked about it together yesterday at the Bindings call.

tl;dr:

  • give folks this week to do any last review/feedback
    • ask @andreasgriffin (might have been asked already, but asking him on the PR) if he's cool w it (assume he is)
  • double check other places we use/reference 3.8/3.9 in the codebase other than this, and remove too if needed (can be done by anyone in a follow up PR)

@andreasgriffin
Copy link
Contributor

Fine by me 👍

@reez
Copy link
Collaborator

reez commented Jun 13, 2025

ACK 693ccb9

We can merge this next week, after rebase (which I can even do if needed, nbd), no rush, and I've got a small follow up PR that removes a couple other 3.8/3.9

Thanks for opening this PR 👍

Python 3.9 is 5 years old. The CI builds the Python binary for every
platform and every version from 3.8-latest, but hasn't caught a
significant issue.
@rustaceanrob
Copy link
Collaborator Author

Rebased

@reez reez merged commit b945297 into bitcoindevkit:master Jun 16, 2025
2 checks passed
@reez reez mentioned this pull request Jun 16, 2025
8 tasks
@rustaceanrob rustaceanrob deleted the py-ci-6-6 branch June 18, 2025 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants