BIPs 174 and 375: fix PSBT_OUT_SP_V0_LABEL value #1754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Assuming a by one increment in the keytype of the silent payments output fields, the following numeral to 0x09 in the hexadecimal system is 0x0a, not 0x10.
jonatack
reviewed
Jan 31, 2025
| @@ -128,7 +128,7 @@ The new per-output types are defined as follows: | |||
| | 2 | |||
| |- | |||
| | Silent Payment Label | |||
| | <tt>PSBT_OUT_SP_V0_LABEL = 0x10</tt> | |||
| | <tt>PSBT_OUT_SP_V0_LABEL = 0x0a</tt> | |||
There was a problem hiding this comment.
Per git blame, this was added in 4a7a7cf.
| @@ -715,7 +715,7 @@ required for aggregation. If sorting was done, then the keys must be in the sort | |||
| | [[bip-0375.mediawiki|375]] | |||
| |- | |||
| | Silent Payment Label | |||
| | <tt>PSBT_OUT_SP_V0_LABEL = 0x10</tt> | |||
| | <tt>PSBT_OUT_SP_V0_LABEL = 0x0a</tt> | |||
There was a problem hiding this comment.
Per git blame, this was added in commit eb10cdb.
jonatack
changed the title
PSBT_OUT_SP_V0_LABEL: "decimal increment" instead of hexadecimal increment
jonatack
added
the
Pending acceptance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assuming a by one increment in the keytype of the silent payments output fields, the following numeral to 0x09 in the hexadecimal system is 0x0a, not 0x10.