Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BIP-329: correct type error #1749

Closed
wants to merge 1 commit into from
Closed

BIP-329: correct type error #1749

wants to merge 1 commit into from

Conversation

doc-hex
Copy link

@doc-hex doc-hex commented Jan 23, 2025

Correct string used as bool in example JSON

@murchandamus
Copy link
Contributor

cc: @craigraw

@xavierfiechter xavierfiechter mentioned this pull request Jan 28, 2025
Open
jonatack
jonatack reviewed Jan 31, 2025
View reviewed changes
Copy link
Member

@jonatack jonatack left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. This change is already present in 58d1ef5 of your PR #1750, so if you don't mind am closing for now as a duplicate. Happy to re-open later if that PR does not move forward or if this one sees BIP author approval.

@jonatack jonatack closed this Jan 31, 2025
@jonatack jonatack mentioned this pull request Jan 31, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonatack jonatack jonatack left review comments

Assignees
No one assigned
Labels
Bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@doc-hex @murchandamus @jonatack