-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BIP 77: Payjoin Version 2 — Async Payjoin #1483
Open
DanGould
wants to merge
50
commits into
bitcoin:master
Choose a base branch
from
DanGould:pjv2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+560
−0
Open
Changes from 1 commit
Commits
Show all changes
50 commits
Select commit
Hold shift + click to select a range
5e2f2aa
Draft payjoin v2 BIP
DanGould 3df3f51
Include mailing list feedback
DanGould 936d0e7
Include TABConf feedback
DanGould 4069db5
Include padding
DanGould 45daed4
Include production reference implementation
DanGould b593c45
Adopt BIP-77 for payjoin v2
DanGould 6becb34
Distinguish payjoin directory from OHTTP Relay
DanGould 754e287
Detail OHTTP Key Configuration mechanism
DanGould 80b8bac
Fix punctuation
DanGould b5353b5
Make base64URL references consistent
DanGould 9e8b4d7
Reference standardized Secp256k1 DHKEM for HPKE
DanGould 3c1629b
Add Comments-URI
DanGould a0d3654
fixup: Format and spell check
DanGould b758311
Add BIP 77 to README
DanGould 95a3b14
Add Payjoin V2 overview diagram
DanGould 6646e99
Add Oblivious HTTP Sequence Diagram
DanGould 5ff5b7a
Correct links and spelling
DanGould ce66047
Wrap <code> blocks
DanGould 07db553
Fix basic scheme actors
DanGould b693fb9
Fix dead samourai links
DanGould f9b4b91
Orient motivation around a problem
DanGould bc3123e
fix links
DanGould 35ebad8
Keyconfig s/should/must/ be provided
DanGould 224208c
Fix typos
DanGould d7ffad8
s/pubkey/public key
DanGould 3b863a4
Incorporate jonatack's suggestions
DanGould f86fe41
Incorporate more jonatack suggestions
DanGould 5c65c21
Incorporate satsie's suggesetions
DanGould b701ade
Rename "Async Payjoin"
DanGould 93b1e60
Replace BIP21 params with fragment params
DanGould 7e7b3b4
Revise document to describe Payjoin Sessions
DanGould df3bd52
Revise Sequence Diagram
DanGould dc4a975
Spell initialize
DanGould 87f892d
Update the bip to represent the stable protocol
DanGould 11b1b83
Spell according to Type Checks's job
DanGould e44f748
Mention the format of the ohttp fragment
DanGould f7a5d25
Reference BIP 78 attack vectors
DanGould 3b7be8c
Remove straggling text
DanGould 66457a0
Specify authorization mechanism
DanGould c917eab
Use implicit session initialization
DanGould 3046520
Specify cryptographic handshake based on Noise IK
DanGould 28f064b
Add Spacebear's clarifications
DanGould 915258a
Document subdirectory Short IDs
DanGould 113c237
Require uppercase URL
DanGould a2b8009
Specify bech32 fragment parameter definitions
DanGould 952156e
Uppercase URL specifically only after subdirectory
DanGould 73941ab
Note payload uniformity via padding and ellswift
DanGould 4853f5a
Include Message Byte Representations
DanGould 69ae3f1
Document HPKE `info` strings
DanGould 799e8c1
Truncate lines to 120 characters
DanGould File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Note payload uniformity via padding and ellswift
- Loading branch information
commit 73941ab3d16b2f432ac25c7c6cbe11790cfb60b9
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’m surprised that the sequence diagram above was drawn in ASCII, while this is an image. Perhaps both should be provided in the same style.