Skip to content

feat(SPV-1537): migrate webhooks #956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

jakubmkowalski
Copy link
Contributor

Pull Request Checklist

  • πŸ“– I created my PR using provided : CODE_STANDARDS
  • πŸ“– I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • βœ… I have provided tests for my changes.
  • πŸ“ I have used conventional commits.
  • πŸ“— I have updated any related documentation.
  • πŸ’Ύ PR was issued based on the Github or Jira issue.

@jakubmkowalski jakubmkowalski self-assigned this Mar 6, 2025
@jakubmkowalski jakubmkowalski requested a review from a team as a code owner March 6, 2025 17:26
Copy link

github-actions bot commented Mar 6, 2025

Manual Tests

ℹ️ Remember to ask team members to perform manual tests and to assign tested label after testing.

@codecov-commenter
Copy link

codecov-commenter commented Mar 6, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 29.74359% with 137 lines in your changes missing coverage. Please review.

Project coverage is 34.46%. Comparing base (3ad6ae4) to head (45a26b1).

Files with missing lines Patch % Lines
api/gen.models.go 0.00% 86 Missing ⚠️
api/gen.api.go 0.00% 33 Missing ⚠️
actions/v2/admin/internal/mapping/webhook.go 0.00% 13 Missing ⚠️
actions/v2/admin/webhooks/get.go 42.85% 3 Missing and 1 partial ⚠️
actions/v2/merkleroots/server.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #956      +/-   ##
==========================================
- Coverage   34.50%   34.46%   -0.05%     
==========================================
  Files         437      442       +5     
  Lines       20826    21020     +194     
==========================================
+ Hits         7186     7244      +58     
- Misses      13041    13176     +135     
- Partials      599      600       +1     
Flag Coverage Ξ”
unittests 34.46% <29.74%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Ξ”
actions/v2/admin/server.go 100.00% <100.00%> (ΓΈ)
actions/v2/admin/webhooks/server.go 100.00% <100.00%> (ΓΈ)
actions/v2/admin/webhooks/subscribe.go 100.00% <100.00%> (ΓΈ)
actions/v2/admin/webhooks/unsubscribe.go 100.00% <100.00%> (ΓΈ)
actions/v2/merkleroots/server.go 0.00% <0.00%> (ΓΈ)
actions/v2/admin/webhooks/get.go 42.85% <42.85%> (ΓΈ)
actions/v2/admin/internal/mapping/webhook.go 0.00% <0.00%> (ΓΈ)
api/gen.api.go 0.00% <0.00%> (ΓΈ)
api/gen.models.go 0.00% <0.00%> (ΓΈ)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update 3ad6ae4...45a26b1. Read the comment docs.

πŸš€ New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

return
}

if bodyReq.Url == "" {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider checking if it has proper URL format, like this:

_, err := url.Parse(cc.Host)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple lines below 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants