Skip to content

feat(SPV-1592): create engine v2 #954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat(SPV-1592): create engine v2 #954

wants to merge 3 commits into from

Conversation

dorzepowski
Copy link
Collaborator

Pull Request Checklist

  • πŸ“– I created my PR using provided : CODE_STANDARDS
  • πŸ“– I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • βœ… I have provided tests for my changes.
  • πŸ“ I have used conventional commits.
  • πŸ“— I have updated any related documentation.
  • πŸ’Ύ PR was issued based on the Github or Jira issue.

@dorzepowski dorzepowski requested a review from a team as a code owner March 6, 2025 14:59
Copy link

github-actions bot commented Mar 6, 2025

Manual Tests

ℹ️ Remember to ask team members to perform manual tests and to assign tested label after testing.

@codecov-commenter
Copy link

codecov-commenter commented Mar 6, 2025

Codecov Report

Attention: Patch coverage is 1.66667% with 472 lines in your changes missing coverage. Please review.

Project coverage is 33.58%. Comparing base (74de94f) to head (316f54b).

Files with missing lines Patch % Lines
engine/v2/engine/engine.go 0.00% 151 Missing ⚠️
engine/v2/engine/internal/storage.go 0.00% 120 Missing ⚠️
engine/v2/engine/paymail.go 0.00% 53 Missing ⚠️
engine/v2/fee/fee_service.go 0.00% 39 Missing ⚠️
engine/v2/engine/internal/cache.go 0.00% 34 Missing ⚠️
actions/v2/callback/callbacks.go 0.00% 24 Missing ⚠️
engine/client.go 0.00% 13 Missing and 2 partials ⚠️
engine/v2/engine/engine_overrides.go 0.00% 12 Missing ⚠️
engine/v2/utils/must/must.go 0.00% 10 Missing ⚠️
actions/v2/register.go 0.00% 4 Missing ⚠️
... and 5 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #954      +/-   ##
==========================================
- Coverage   34.50%   33.58%   -0.92%     
==========================================
  Files         437      444       +7     
  Lines       20826    21167     +341     
==========================================
- Hits         7186     7109      -77     
- Misses      13041    13461     +420     
+ Partials      599      597       -2     
Flag Coverage Ξ”
unittests 33.58% <1.66%> (-0.92%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Ξ”
engine/client_internal.go 65.38% <100.00%> (-5.34%) ⬇️
engine/client_options.go 66.27% <ΓΈ> (+0.62%) ⬆️
engine/definitions.go 100.00% <100.00%> (+15.78%) ⬆️
engine/paymail/paymail_service_client.go 51.07% <100.00%> (ΓΈ)
initializer/config_to_options.go 0.00% <ΓΈ> (ΓΈ)
actions/transactions/broadcast_callback.go 0.00% <0.00%> (ΓΈ)
...gine/v2/database/testabilities/fixture_database.go 0.00% <0.00%> (ΓΈ)
...ngine/v2/paymailserver/paymail_service_provider.go 0.00% <0.00%> (ΓΈ)
server/server.go 7.31% <60.00%> (+1.14%) ⬆️
actions/v2/register.go 0.00% <0.00%> (ΓΈ)
... and 10 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update 74de94f...316f54b. Read the comment docs.

πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dorzepowski dorzepowski added the regression-tests Runs regression tests label Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression-tests Runs regression tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants