New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: color-control in react 17 and setValue to hex #30

Merged

birkir merged 1 commit into birkir:master from guigallo:master

Dec 10, 2020

Contributor

guigallo commented Nov 26, 2020 •

edited

Loading

#29 This pull request is fixing two bugs:

handleClick was always closing the colorbox, so, I added to then an id and prevent setOpen dont get called when clicked in it. This behavior was only occured in react ˆ17.
onChange color was setting value with rbg object instead of hex, which is the standard of color-control.

Changes was tested in react 16 and 17 versions.


          fix: color-control in react 17 and setValue to hex

birkir merged commit 0122bd8 into birkir:master

Owner

birkir commented Dec 10, 2020

Thank you

ffdead mentioned this pull request

ColorControl breaks with React 17 #29

Open

servinlp mentioned this pull request

New release #42

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet