Fixed the createTemplate not working on iOS #166
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it's better if we handle this natively to maintain method parity between iOS and Android. I opened #167 as an alternative. |
This is one thing that we can argue about for decades 😁. My personal preference is to keep the native side as simple as possible(without any abstraction) and move the abstraction to the JS side. This makes it possible to implement complex logic in the future if that need ever arises. However, for this one, I'm good either way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What has changed?
createTemplatenot working on iOS due to the difference in number of arguments.Demos
Before
Kapture.2024-01-28.at.19.03.16.mp4
After
Kapture.2024-01-28.at.19.09.03.mp4
This PR is based on #162